Closed sourcery-ai[bot] closed 3 years ago
β Merging this PR will increase code quality in the affected files by 0.44%.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 8.48 β | 7.95 β | -0.53 π |
Method Length | 70.67 π | 70.06 π | -0.61 π |
Working memory | 9.81 π | 9.75 π | -0.06 π |
Quality | 62.04% π | 62.48% π | 0.44% π |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 3254 | 3211 | -43 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
benchmark/benchmark_dev_team.py | 48.16% π | 48.16% π | 0.00% |
benchmark/benchmark_mixed.py | 38.18% π | 40.42% π | 2.24% π |
processscheduler/base.py | 86.75% β | 87.70% β | 0.95% π |
processscheduler/cost.py | 83.67% β | 85.13% β | 1.46% π |
processscheduler/jupyter_ui.py | 71.52% π | 71.89% π | 0.37% π |
processscheduler/problem.py | 71.32% π | 72.23% π | 0.91% π |
processscheduler/solution.py | 41.45% π | 40.10% π | -1.35% π |
processscheduler/solver.py | 40.92% π | 41.78% π | 0.86% π |
processscheduler/task_constraint.py | 72.68% π | 73.24% π | 0.56% π |
test/test_indicator.py | 74.01% π | 74.01% π | 0.00% |
test/test_solver.py | 75.22% β | 75.16% β | -0.06% π |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|---|---|---|---|---|---|
processscheduler/solution.py | SchedulingSolution.render_gantt_matplotlib | 42 β | 544 β | 20 β | 9.40% β | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
processscheduler/solver.py | SchedulingSolver.build_solution | 41 β | 371 β | 12 π | 19.77% β | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
processscheduler/solver.py | SchedulingSolver.solve_optimize_incremental | 29 π | 290 β | 15 π | 22.30% β | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
processscheduler/solution.py | SchedulingSolution.render_gantt_plotly | 22 π | 283 β | 16 β | 25.54% π | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
processscheduler/solver.py | SchedulingSolver.__init__ | 19 π | 290 β | 12 π | 32.75% π | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
The emojis denote the absolute quality of the code:
The π and π indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
Merging #86 (053b4c9) into master (e0e3a01) will increase coverage by
0.15%
. The diff coverage is83.33%
.
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
+ Coverage 94.96% 95.11% +0.15%
==========================================
Files 30 30
Lines 3417 3380 -37
==========================================
- Hits 3245 3215 -30
+ Misses 172 165 -7
Impacted Files | Coverage Ξ | |
---|---|---|
processscheduler/jupyter_ui.py | 44.50% <0.00%> (+1.42%) |
:arrow_up: |
test/test_indicator.py | 99.52% <ΓΈ> (ΓΈ) |
|
processscheduler/solver.py | 96.32% <66.66%> (+0.30%) |
:arrow_up: |
processscheduler/base.py | 94.54% <100.00%> (-0.20%) |
:arrow_down: |
processscheduler/cost.py | 85.36% <100.00%> (-0.69%) |
:arrow_down: |
processscheduler/problem.py | 97.12% <100.00%> (-0.12%) |
:arrow_down: |
processscheduler/solution.py | 94.59% <100.00%> (-0.33%) |
:arrow_down: |
processscheduler/task_constraint.py | 100.00% <100.00%> (ΓΈ) |
|
test/test_solver.py | 99.64% <100.00%> (-0.01%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update e0e3a01...053b4c9. Read the comment docs.
Branch
master
refactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
master
branch, then run:Help us improve this pull request!