Closed sourcery-ai[bot] closed 3 years ago
β Merging this PR will decrease code quality in the affected files by 0.48%.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 8.79 π | 8.91 π | 0.12 π |
Method Length | 93.86 π | 93.29 π | -0.57 π |
Working memory | 10.80 π | 10.90 π | 0.10 π |
Quality | 54.12% π | 53.64% π | -0.48% π |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 225 | 222 | -3 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
processscheduler/resource_constraint.py | 54.12% π | 53.64% π | -0.48% π |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|---|---|---|---|---|---|
processscheduler/resource_constraint.py | WorkLoad.__init__ | 13 π | 257 β | 14 π | 35.94% π | Try splitting into smaller methods. Extract out complex expressions |
processscheduler/resource_constraint.py | ResourceTasksDistance.__init__ | 8 β | 166 π | 11 π | 51.56% π | Try splitting into smaller methods. Extract out complex expressions |
The emojis denote the absolute quality of the code:
The π and π indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
Merging #88 (5a4e4b3) into resource-tasks-distance (cac8b4a) will decrease coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## resource-tasks-distance #88 +/- ##
===========================================================
- Coverage 95.07% 95.06% -0.01%
===========================================================
Files 31 31
Lines 3551 3549 -2
===========================================================
- Hits 3376 3374 -2
Misses 175 175
Impacted Files | Coverage Ξ | |
---|---|---|
processscheduler/resource_constraint.py | 95.78% <100.00%> (-0.09%) |
:arrow_down: |
test/test_resource_tasks_distance.py | 99.00% <100.00%> (ΓΈ) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update cac8b4a...5a4e4b3. Read the comment docs.
Pull Request #87 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will re-run and update (force-push) this Pull Request with new refactorings as necessary. If Sourcery finds no refactorings at any point, this Pull Request will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
resource-tasks-distance
branch, then run:Help us improve this pull request!