Sourcery refactored master branch

[sourcery-ai[bot]]

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

[sourcery-ai[bot]]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.36%.

Quality metrics	Before	After	Change
Complexity	2.25 ⭐	1.99 ⭐	-0.26 👍
Method Length	71.29 🙂	70.90 🙂	-0.39 👍
Working memory	9.38 🙂	9.31 🙂	-0.07 👍
Quality	68.18% 🙂	68.54% 🙂	0.36% 👍

Other metrics	Before	After	Change
Lines	2406	2386	-20

Changed files	Quality Before	Quality After	Quality Change
benchmark/benchmark_dev_team.py	48.16% 😞	48.16% 😞	0.00%
benchmark/benchmark_mixed.py	38.18% 😞	40.42% 😞	2.24% 👍
processscheduler/base.py	85.75% ⭐	86.74% ⭐	0.99% 👍
processscheduler/cost.py	83.67% ⭐	85.13% ⭐	1.46% 👍
processscheduler/jupyter_ui.py	71.52% 🙂	71.89% 🙂	0.37% 👍
processscheduler/problem.py	71.32% 🙂	72.23% 🙂	0.91% 👍
processscheduler/util.py	75.24% ⭐	75.34% ⭐	0.10% 👍
test/test_indicator.py	74.01% 🙂	74.01% 🙂	0.00%
test/test_resource_tasks_distance.py	57.71% 🙂	58.04% 🙂	0.33% 👍
test/test_solver.py	75.22% ⭐	75.16% ⭐	-0.06% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
test/test_resource_tasks_distance.py	TestResourceTasksDistance.test_resource_tasks_distance_double_time_period_2	1 ⭐	303 ⛔	15 😞	44.24% 😞	Try splitting into smaller methods. Extract out complex expressions
processscheduler/problem.py	SchedulingProblem.add_objective_flowtime_single_resource	4 ⭐	206 ⛔	12 😞	50.35% 🙂	Try splitting into smaller methods. Extract out complex expressions
test/test_indicator.py	TestIndicator.get_single_resource_utilization_problem	0 ⭐	202 😞	14 😞	51.64% 🙂	Try splitting into smaller methods. Extract out complex expressions
test/test_solver.py	TestSolver.test_alternative_workers_2	0 ⭐	156 😞	17 ⛔	52.31% 🙂	Try splitting into smaller methods. Extract out complex expressions
test/test_resource_tasks_distance.py	TestResourceTasksDistance.test_resource_tasks_distance_4	0 ⭐	199 😞	13 😞	53.28% 🙂	Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

[codecov-commenter]

Codecov Report

Merging #94 (4bd47f4) into master (5e1988f) will increase coverage by 0.13%. The diff coverage is 78.57%.

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   94.94%   95.07%   +0.13%     
==========================================
  Files          34       34              
  Lines        3857     3838      -19     
==========================================
- Hits         3662     3649      -13     
+ Misses        195      189       -6     

Impacted Files	Coverage Δ
processscheduler/jupyter_ui.py	44.50% <0.00%> (+1.42%)	:arrow_up:
test/test_indicator.py	99.52% <ø> (ø)
processscheduler/base.py	94.11% <100.00%> (-0.23%)	:arrow_down:
processscheduler/cost.py	85.71% <100.00%> (-0.65%)	:arrow_down:
processscheduler/problem.py	97.14% <100.00%> (-0.12%)	:arrow_down:
processscheduler/util.py	57.14% <100.00%> (-2.32%)	:arrow_down:
test/test_resource_tasks_distance.py	99.46% <100.00%> (ø)
test/test_solver.py	99.64% <100.00%> (-0.01%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5e1988f...4bd47f4. Read the comment docs.