search

tpaviot / oce

OpenCASCADE Community Edition (OCE): a community driven fork of the Open CASCADE library.
http://groups.google.com/group/oce-dev
GNU Lesser General Public License v2.1
811 stars 284 forks source link

Fix clock_gettime detection on osx #654

Closed xzcvczx closed 7 years ago

xzcvczx commented 7 years ago

this should future proof the clock_gettime detection and whether to include gettime_osx.h on OSX. I have been unable to test on a system without clock_gettime so it should probably be checked

tpaviot commented 7 years ago

@xzcvczx that sounds ok, I was about to push the same fix. Waiting for travis and appveyor builds to complete before merging

xzcvczx commented 7 years ago

oh my bad, wasn't sure when you would get a chance to do it so thought i might try and help out

tpaviot commented 7 years ago

@xzcvczx Can u please rebase your branch onto master ? I updated the travis build so that osx is part of the test. Travis runs an old xcode version, we can check if your fix passes on a system without clock_gettime

johntfoster commented 7 years ago

Can I do something to help get this merged?

xzcvczx commented 7 years ago

yeah sorry, do you want to fix up the patch so it merges cleanly, I have just been very busy recently and have no time to do anything with it

thanks

On 16 March 2017 at 00:05, John T. Foster notifications@github.com wrote:

Can I do something to help get this merged?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tpaviot/oce/pull/654#issuecomment-286710222, or mute the thread https://github.com/notifications/unsubscribe-auth/ACr4PLqQ72i0U1KxHteidTfaRdbae1IMks5rl8YQgaJpZM4LqB6E .

-- hello