search

tpaviot / oce

OpenCASCADE Community Edition (OCE): a community driven fork of the Open CASCADE library.
http://groups.google.com/group/oce-dev
GNU Lesser General Public License v2.1
811 stars 284 forks source link

OCE cmakefiles don't work with cmake 3.7 FindFreetype module #655

Open viric opened 7 years ago

viric commented 7 years ago

In cmake 3.6 FindFreetype returned a FREETYPE_LIBRARIES including only the "Release" version of the lib. In cmake 3.7 it returns the usual "optimized;release-lib;debug;debug-lib" string. This fails in TKService CMakeLists.txt:

https://github.com/tpaviot/oce/blob/master/adm/cmake/TKService/CMakeLists.txt#L50

The cmake commit that made the change for cmake 3.7:

https://github.com/tpaviot/oce/blob/master/adm/cmake/TKService/CMakeLists.txt#L50

So OCE cmakelists should be updated for cmake 3.7.

viric commented 7 years ago

Oh I forgot to tell where the error happens. The error happens when the BuldToolkit tries to build the "optimized;...;debug;..." kind of libraries when the source already is a string like this. It ends up being "optimzied;optimized;...." giving a cmake error.

Here is the line doing the assembly that has double "optimized" for freetype:

https://github.com/tpaviot/oce/blob/master/adm/cmake/BuildToolkit.cmake#L251