Fix build error with glibc 2.26, xlocale.h

tpaviot / oce

OpenCASCADE Community Edition (OCE): a community driven fork of the Open CASCADE library.

http://groups.google.com/group/oce-dev

GNU Lesser General Public License v2.1

811 stars 284 forks source link

Fix build error with glibc 2.26, xlocale.h #689

Closed rsm-gh closed 6 years ago

rsm-gh commented 6 years ago

While building on archilinux I found an xlocale.h problem. The fast solution was to comment the #include <xlocale.h> line of the /src/Standard/Standard_CLocaleSentry.cxx file.

Here are more details taken from this thread

Do not include xlocale.h on systems, where GLIBC is defined xlocale.h has been removed from glibc 2.26 The include of locale.h in asyncrt_utils.h is sufficient Further details: https://sourceware.org/git/?p=glibc.git;a=commit;h=f0be25b

Kind regards, rsm

janusw commented 6 years ago

aa1321e68cc004e3debe38d79ae74581a617c767 should actually fix this. Which version did you use?

rsm-gh commented 6 years ago

I'm gonna close this because I'm starting to think that the day I posted this I did something wrong with the compilation. Yesterday I re-made it without any problem.

OCE version: 0.18.3 glibc: 2.26-11

Thanks anyways, rsm