search

tpaviot / pythonocc-demos

Examples and demos for the pythonocc CAD package
219 stars 117 forks source link

Fixed postioning and colors for core_load_step_with_colors.py #6

Closed Rayfoundry closed 5 years ago

Rayfoundry commented 6 years ago

Note: Use a complex stp files using references to see difference. This should fix https://github.com/tpaviot/pythonocc-core/issues/412

This is not a bugfix but just changes the behavior of the example to be more in line what a user would expect. Basically it makes sure that all labels are loaded, colors are extracted and then the visible parts are displayed. The base parts of instances are omited and not rendered.

jf--- commented 6 years ago

Nice catch @Rayfoundry 👍
One way this might be further advanced is by adding an assert statement. By adding assert to a demo, we can think of these as integration tests.