search

tpavlek / oauth2-twitch

A Twitch provider for the php league's oauth2-client
18 stars 12 forks source link

Not compatible with 2.0 version of league/oauth2-client #8

Closed MadMikeyB closed 7 years ago

MadMikeyB commented 7 years ago

Because in composer.json you list the following:

"league/oauth2-client": "^1.3",

Upon upgrading to league/oauth2-client 2.0, I can no longer use this version. Composer spits out an error.

Could you confirm whether this is compatible with league/oauth2-client 2.0 ? All the official league/ providers now require 2.0, so I cannot downgrade.

Thanks!

tpavlek commented 7 years ago

I haven't upgraded this. I'd happily accept a pull - otherwise it'll have to compete with my busy schedule

On Feb 25, 2017 3:56 PM, "Michael Burton" notifications@github.com wrote:

Because in composer.json you list the following:

"league/oauth2-client": "^1.3",

Upon upgrading to league/oauth2-client 2.0, I can no longer use this version. Composer spits out an error.

Could you confirm whether this is compatible with league/oauth2-client 2.0 ? All the official league/ providers now require 2.0, so I cannot downgrade.

Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tpavlek/oauth2-twitch/issues/8, or mute the thread https://github.com/notifications/unsubscribe-auth/AAvw8CJwmBpvjLxB5IYc9Fvr9ayYHyvVks5rgLGNgaJpZM4MMKv7 .

MadMikeyB commented 7 years ago

Thanks for the reply - I will look into submitting a PR.

0plus1 commented 7 years ago

HI @MadMikeyB,

I just pushed a commit to address this issue, please change your require in composer.json to pull from master and you will be sorted, if you can please report back if it works without issues I will create an official release.

Thanks

tristanbes commented 7 years ago

Hello, @0plus1 // @tpavlek

Is that possible to tag a new release of your bundle (compliant with league/oauth2-client 2.0) ? I don't like to put dev-master on my composer.json

I've been using your patch without any problem so far.

Thanks.

tpavlek commented 7 years ago

@tristanbes a new release was just tagged.

tristanbes commented 7 years ago

Thanks.