search

tpay-com / tpay-php

MIT License
24 stars 27 forks source link

Problems with parseTemplate. #31

Closed zimdin12 closed 10 months ago

zimdin12 commented 2 years ago

In parseTemplate @L64($parsedHTML = ob_get_contents();) & L65(ob_clean();) are cousing my page to break. Header of my page is misplaced inside of the rendered tpay html. I am using blade templating engine. If I replace L64 with $parsedHTML = ob_get_clean(); and remove L65 then everything is working well and other parts of the site are fine. Does somebody have good solution so i would not have to fork this repo ?

mzawodzinski commented 2 years ago

This template system is completely no sense and stupid. Templates and logs system makes this lib almost useless. Please remove this, lib should return raw data not templates.

gstarczyk commented 2 years ago

Hi @zimdin12 I cannot reproduce such behaviour.

Can you provide some exemplary "blade" template (along with CSS) where this issue occurs? Maybe this issue is connected more with CSS thant HTML structure?

Also it would be great if you share your PHP and Blade version.

kwojc commented 10 months ago

@mzawodzinski Logs system is rewritten now. You can pass any of PSR Compatible loggers.

zimdin12 commented 2 months ago

I just updated deps and I can confirm that this has been fixed on 2.4.7. Now i have cleaner code without weird temp overrides :D