Add parameter ReportConfigFile to allow custom report config

UnknownGnome commented 5 years ago

Description

Add parameter to allow custom ReportConfigFile. If the custom file isn't provided, ti defaults to the original location at "$PSScriptRoot\Reports\$Type\$Type.json"

Related Issue

Motivation and Context

Allow script to run with different details needed at different times.

How Has This Been Tested?

Tested against 6.7 vCenter

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.

mattallford commented 5 years ago

Hi @UnknownGnome,

Thanks for taking the time to submit a PR to the project!

Tim and I have done a bad job of communicating this, but we are working on migrating the project to a very modular topology and in doing so, we have also brought similar functionality in to the re-written project.

I'll leave it up to @tpcarman as to whether to merge this PR, but we're hoping to release the new version in the next 2 weeks and this repository will then be redirected to the new Github organisation repository.

Would you be open to being a tester on the new modular version of the project for us?

Cheers, Matt.

UnknownGnome commented 5 years ago

No problem. Whatever you want to do . I'd be happy to test out the new version when it's ready.

tpcarman commented 5 years ago

Feature added to https://github.com/AsBuiltReport/AsBuiltReport.Core/commit/702be10152818dda487f9a62919fc374d23ffeeb

tpcarman / As-Built-Report