tpcofficial / big-oauth2

A OAuth2 module to easily allow you to integrate your applications authentication with 3rd party IdPs. Returns user data with minimal code to help you create and manage users in your databases!
GNU General Public License v3.0
3 stars 1 forks source link

[Feature] Google OAuth2 flow #10

Closed dudeisbrendan03 closed 3 years ago

dudeisbrendan03 commented 3 years ago

Feature Request

Google OAuth2 Flow

Is your feature request related to a problem? Please describe. No.

Describe the solution you'd like Google OAuth2 flow

github-actions[bot] commented 3 years ago

Welcome to the big-oauth2 project, we love that you've decided to report an issue to help improve our package!

Remeber that most contributors work in their free time, so less import requests (like asking for help) may be delayed in their response.

dudeisbrendan03 commented 3 years ago

Flow initiation working, Google is swapping the query identifier (?) for an octothorp (#)

Response: /oauth2/google/callback#access_token=ABCDE&token_type=Bearer&expires_in=3598&scope=email%20profile%20https://www.googleapis.com/auth/userinfo.email%20https://www.googleapis.com/auth/userinfo.profile%20openid&authuser=0&prompt=none

Expected response: /oauth2/google/callback?access_token=ABCDE&token_type=Bearer&expires_in=3598&scope=email%20profile%20https://www.googleapis.com/auth/userinfo.email%20https://www.googleapis.com/auth/userinfo.profile%20openid&authuser=0&prompt=none

dudeisbrendan03 commented 3 years ago

startFlow() generates a valid, correct URL for consent, but for some reason after consent the URL returned (with the query string data we need) does not use the standard (? - Query string identifier) but a #.

Cannot see an issue from my side which would cause this.

https://accounts.google.com/o/oauth2/v2/auth?client_id=682095607327-5qrc4cd07r7qdpmq88mh17ploh6noeuu.apps.googleusercontent.com&response_type=token&scope=https://www.googleapis.com/auth/userinfo.email+https://www.googleapis.com/auth/userinfo.profile&redirect_uri=http://big-oauth2.beta.thatspretty.cool/oauth2/google/callback

Google Provider module

dudeisbrendan03 commented 3 years ago

@0xh4sh

dudeisbrendan03 commented 3 years ago

Track issue in #14