search

tpecholt / imrad

ImRAD is a GUI builder for the ImGui library
GNU General Public License v3.0
872 stars 26 forks source link

OSX implmentation and nativefiledialog-extended upgrade #23

Closed Super-Genius closed 11 months ago

Super-Genius commented 12 months ago

This enabled OSX and added nativefiledialog-extended submodule that has filters for loading/saving files

Super-Genius commented 12 months ago

Add ability for OSX to build fat binary (x86_64/arm64) for those that requested it

tpecholt commented 11 months ago

Thanks for your PR! Some people requested MacOS support before and I don't own Apple HW so I was not able to add it.

I have few questions: 1) build fails maybe cmake.yml needs to install libsystemd-dev? 2) I see the extended nativefialedialog comes with CMake. What is the benefit of using ExternalProject_Add over add_subdirectory? 3) Why was copying of template, style folders removed from installation step? I use install target to prepare directory structure for github release upload.

Super-Genius commented 11 months ago

  1. yes, i think Installed this manually

  2. This allows to build/rebuild individual projects so

cmake --build . --target nativedialog

otherwise you have to build the entire project just to change nativedialog and test as one of the advantages. Others include isolating CMAKE settings if there are duplicate definitions. i.e If defined(DEBUG) or of defined(TEST)

  1. It copies these to the bin directory when building so you can just copy the whole bin directory