search

tphakala / birdnet-go

Realtime BirdNET soundscape analyzer
Other
189 stars 19 forks source link

Audio player controls are not working #287

Closed tphakala closed 1 month ago

tphakala commented 1 month ago

Hi @tphakala! A very happy user here. This new player looks gorgeous. However, it isn't working for me. It does something, and I can see it in the inspector, but something seems broken. It's happening both in Firefox and Chrome (Fedora Linux in both cases).

https://github.com/user-attachments/assets/1ebace4a-f678-4f35-84dc-9b1d9403c41d

Originally posted by @vibragiel in https://github.com/tphakala/birdnet-go/discussions/285#discussioncomment-10807806

tphakala commented 1 month ago

@vibragiel Can you please open a species detection listing and look for errors in developer mode console on that page? Dashboard recent detections is still using old player so any errors with new player are now showing up while on dashboard.

vibragiel commented 1 month ago

This is the only error that appears just after entering the dashboard:

image

There are no new errors when opening a species detection, and the rest of the page seems to work fine otherwise.

vibragiel commented 1 month ago

FYI, I downgraded to an image from before you introduced the new audio player and the htmx syntax error was there already.

tphakala commented 1 month ago

Yeah that HTMX error is not nice, but it is not related to this issue as there is no HTMX in use for audio player code, just javascript. Does audio player for recent detections work?

vibragiel commented 1 month ago

Does audio player for recent detections work?

Yes, that one works fine.

Tserppa commented 1 month ago

Hi, I can see this issue as well but the new player works if I scale the window down. Just try to scale the window down so it's as narrow as a mobile phone screen.

image

tphakala commented 1 month ago

Which OS are you using @Tserppa Linux?

Tserppa commented 1 month ago

Server is Linux but I'm viewing the dashboard from Windows 11 + Edge.

tphakala commented 1 month ago

OK, I see this also when using docker image from github, I guess docker build workflow is broken. I'll see if I can fix it today. Thanks for reporting @vibragiel and @Tserppa

tphakala commented 1 month ago

Problem is now fixed in image ghcr.io/tphakala/birdnet-go:e96b221de621941fbdcbe2670d450b27802acfe9, I had forgot to commit updated CSS files which broke bunch of things in the UI

Tserppa commented 1 month ago

I can confirm it working now. And btw this is a great update. Thanks @tphakala!

vibragiel commented 1 month ago

Working flawlessly. Thanks!

vibragiel commented 1 month ago

@tphakala Let me know if you need help debugging the htmx syntax error, though it doesn't seem to affect functionality in any way I can see.

tphakala commented 1 month ago

@vibragiel Thanks, HTMX code is directly from HTMX upstream so bug could be simply resolved by updating HTMX library. But I have been thinking of replacing HTMX code with alpine.js + native javascript, haven't made my mind yet though.

vibragiel commented 1 month ago

The htmx error is gone now (perhaps thanks to this?), so as far as I'm concerned, this issue can be closed. Thanks!