search

tpill90 / epic-lancache-prefill

CLI tool to automatically prime a Lancache with Epic Launcher games
https://tpill90.github.io/epic-lancache-prefill/
MIT License
45 stars 4 forks source link

[Bug] Update script still looking for SteamPrefill #10

Closed MrMdemiC closed 1 year ago

MrMdemiC commented 1 year ago

Hi, was trying to get this prefill working but before starting the program i started the update.sh script I was presented with an error so i took a look into the script and found that the #unzip and below it is still looking for SteamPrefill instead off EpicPrefill: # Unzip echo -e "${Yellow} Unzipping... ${NC}" unzip -q -j -o SteamPrefill-${LATEST_TAG}-linux-x64.zip

# Required so executable permissions don't get overwritten by unzip chmod +x SteamPrefill update.sh

# Cleanup rm SteamPrefill-${LATEST_TAG}-linux-x64.zip

When i change the SteamPrefill to EpicPrefill the script runs without errors :)

Velosofy commented 1 year ago

Feel free to make a PR :D

Joly0 commented 1 year ago

Closed this accidentially. @MrMdemiC Can you test and confirm its correct now?

MrMdemiC commented 1 year ago

Feel free to make a PR :D

if i knew how i would love to do it hahahah :P

Closed this accidentially. @MrMdemiC Can you test and confirm its correct now?

i dont think it will work since the release is not updated as off this moment off writing this comment :)

when the release is updated i will test again <3

Joly0 commented 1 year ago

Feel free to make a PR :D

if i knew how i would love to do it hahahah :P

Closed this accidentially. @MrMdemiC Can you test and confirm its correct now?

i dont think it will work since the release is not updated as off this moment off writing this comment :)

when the release is updated i will test again <3

You can take the file from here https://github.com/tpill90/epic-lancache-prefill/suites/10954170053/artifacts/554422811

MrMdemiC commented 1 year ago

Feel free to make a PR :D

if i knew how i would love to do it hahahah :P

Closed this accidentially. @MrMdemiC Can you test and confirm its correct now?

i dont think it will work since the release is not updated as off this moment off writing this comment :) when the release is updated i will test again <3

You can take the file from here https://github.com/tpill90/epic-lancache-prefill/suites/10954170053/artifacts/554422811

this one kinda works 1 time but it looks at the latest release and downloads that one and overrides it... so yes it works but only one time :)

MrMdemiC commented 1 year ago

BTW thanks for the help,, i am no expert in GitHub but just want to help with these small kinda things :D

MrMdemiC commented 1 year ago

also clicking that link downloads zip file named SteamPrefill :)

i understand that this is made quickly and still needs alot off name changing but just pointing out small things ;)

tpill90 commented 1 year ago

Released in v1.1.0