search

tpilz / lumpR

Landscape Unit Mapping Program for R
GNU General Public License v3.0
11 stars 12 forks source link

R CMD check issues in v1.0.0 (RainySeason.f) #23

Open tpilz opened 9 years ago

tpilz commented 9 years ago

Running R CMD check LUMP for release v1.0.0 produces one warning and one note which still have to be resolved:

Compiler warnings from RainySeason.f:

Found the following significant warnings:
  Warning: Possible change of value in conversion from REAL(8) to REAL(4) at (1)
  Warning: Possible change of value in conversion from REAL(8) to REAL(4) at (1)
  Warning: Possible change of value in conversion from REAL(4) to INTEGER(4) at (1)
  Warning: Possible change of value in conversion from REAL(4) to INTEGER(4) at (1)
  Warning: Possible change of value in conversion from REAL(4) to INTEGER(4) at (1)
  Warning: Possible change of value in conversion from REAL(4) to INTEGER(4) at (1)
  Warning: Possible change of value in conversion from REAL(4) to INTEGER(4) at (1)
  Warning: Possible change of value in conversion from REAL(8) to REAL(4) at (1)
  Warning: Possible change of value in conversion from REAL(4) to INTEGER(4) at (1)
  Warning: Possible change of value in conversion from REAL(4) to INTEGER(4) at (1)
  Warning: Possible change of value in conversion from REAL(8) to REAL(4) at (1)
  Warning: Possible change of value in conversion from REAL(4) to INTEGER(4) at (1)
  Warning: Possible change of value in conversion from REAL(8) to REAL(4) at (1)
  Warning: Possible change of value in conversion from REAL(4) to INTEGER(4) at (1)
  Warning: Possible change of value in conversion from REAL(8) to REAL(4) at (1)
  Warning: Possible change of value in conversion from REAL(4) to INTEGER(4) at (1)
  Warning: Possible change of value in conversion from REAL(4) to INTEGER(4) at (1)
  Warning: Possible change of value in conversion from REAL(4) to INTEGER(4) at (1)
  Warning: Possible change of value in conversion from REAL(4) to INTEGER(4) at (1)
  Warning: Possible change of value in conversion from REAL(4) to INTEGER(4) at (1)
  Warning: Possible change of value in conversion from REAL(4) to INTEGER(4) at (1)

These implicit type conversions might be an issue.

One note regarding calc_seasonality.f90:

* checking compiled code ... NOTE
File ‘/home/tobias/R/R.checks/LUMP.Rcheck/LUMP/libs/LUMP.so’:
  Found ‘_gfortran_stop_string’, possibly from ‘stop’ (Fortran)
    Object: ‘calc_seasonality.o’

Compiled code should not call entry points which might terminate R nor
write to stdout/stderr instead of to the console.

See ‘Writing portable packages’ in the ‘Writing R Extensions’ manual.