search

tpircher-zz / pycrc

Free, easy to use Cyclic Redundancy Check (CRC) calculator and source code generator
https://pycrc.org
MIT License
169 stars 36 forks source link

Added more CRC models to the code #31

Closed rawr51919 closed 5 years ago

rawr51919 commented 5 years ago

Added every CRC model from http://reveng.sourceforge.net/crc-catalogue/all.htm to the models.py as well as checked the existing CRC models against that site, renaming them and making them seperate CRC models if incorrect.

tpircher-zz commented 5 years ago

Hi Colton, this is some serious work you put in, I'm very impressed. However, I have to reject this request. I don't think pycrc should have an exhaustive catalogue of CRC models, and I have in the past even contemplated to reduce the list of models.

If accepted, this change would require me to monitor and incorporate future changes and fixes from the CRC catalogue on an ongoing basis, a workload I'm not willing to take on, unfortunately.

rawr51919 commented 5 years ago

That's OK. I'll probably keep my fork open for those who really need to have not only all those models, but also have their hashes be as accurate as possible to the real thing (which is especially important in the usage case I'm wanting to use it in).