search

tpisto / pdf-fill-form

Fill PDF forms and return either filled PDF or PDF created from rendered page images.
MIT License
227 stars 48 forks source link

Version 5.0.0 doesn't compile #79

Closed thehappycoder closed 4 years ago

thehappycoder commented 4 years ago

Nodejs version: 10

../src/NodePoppler.cc:273:58: error: no matching function for call to 'v8::Value::BooleanValue(v8::Isolate*&)'
       antialiasing = antialiasParam->BooleanValue(isolate);

Switched back to previous version for now.

dfharmon commented 4 years ago

I have a PR around this issue -- https://github.com/tpisto/pdf-fill-form/pull/80

florianbepunkt commented 4 years ago

my bad, sorry for the troubles. I ported this to node 13 without testing different node versions as (noted this in the PR)

tpisto commented 4 years ago

@dfharmon Thank you for your PR