search

tpitale / mail_room

Forward mail from gmail IMAP to a callback URL or job worker, simply.
MIT License
195 stars 51 forks source link

Improve Microsoft Graph error handling #127

Closed stanhu closed 3 years ago

stanhu commented 3 years ago

If the wrong credentials or permissions are set for a Microsoft Graph inbox, MailRoom will go into a tight loop of retrying the request to no avail. https://docs.microsoft.com/en-us/graph/errors lists all the possible errors. In most cases, we just want to terminate with a hard failure since there is something the admin needs to check.

stanhu commented 3 years ago

@tpitale Would you mind looking at this and the other pull requests?

stanhu commented 3 years ago

@tpitale Sorry to bother you again, but could you take a look at this?

tpitale commented 3 years ago

Could you answer my question?

stanhu commented 3 years ago

@tpitale Sorry, I'm not seeing the question. Is there an outstanding review to be submitted?

tpitale commented 3 years ago

Sorry @stanhu, that "review" was sitting on my phone for a few weeks 😆 The mobile UI doesn't have a button for submitting a review or something 🤔