search

tpitale / mail_room

Forward mail from gmail IMAP to a callback URL or job worker, simply.
MIT License
193 stars 51 forks source link

Add missing dependency requirements #138

Closed 0x2c7 closed 2 years ago

0x2c7 commented 2 years ago

In https://github.com/tpitale/mail_room/pull/134, I added header-based JWT authentication to postback strategy. The unit tests were green. Manual testing on GitLab codebase yielded no concerns. However, when I tried to start mail_room with vanilla built-in binary, the program crashes:

Screen Shot 2022-01-19 at 12 55 22

It turns out, I forgot to load jwt and base64 before using them. It's a really silly mistake 🤦. Those two gems are already loaded in GitLab codebase. Somehow, while running full test suite in this repository, they are automatically loaded. The test fails when running bundle exec rspec spec/lib/jwt_spec.rb individually.

0x2c7 commented 2 years ago

@stanhu Could you have a look at this PR? Sorry for bragging you into this silliness 🙏