search

tpitale / mail_room

Forward mail from gmail IMAP to a callback URL or job worker, simply.
MIT License
193 stars 51 forks source link

Specify Redis gems as required dependencies #154

Open stanhu opened 1 year ago

stanhu commented 1 year ago

We recently came across a Ruby 3 compatibility issue with redis-namespace and MailRoom that required updating to redis-namespace v1.8.x (https://github.com/resque/redis-namespace/blob/master/CHANGELOG.md). Since the gemspec did not specify a version, we have to install the required Redis gems by hand and missed the need for updating.

Adjust tests to support both Redis v4 and v5 gems. Redis v4 may still be needed for Rails 6 compatibility.

stanhu commented 1 year ago

It looks like the specs need to be updated for Redis 5: https://github.com/tpitale/mail_room/actions/runs/4961109521/jobs/8877471798

stanhu commented 1 year ago

@tpitale Curious what you think about this pull request. In general, I think we should move move of the development gems into required gems so we can be sure that the code here works against the specific gem versions, but I can understand that C extensions might be a concern.

stanhu commented 9 months ago

@tpitale What do you think of this pull request and https://github.com/tpitale/mail_room/pull/161?

tpitale commented 9 months ago

I think I worried about this because not everyone uses this delivery method. But I'll have to look on a computer the next chance I get.

If you don't hear from me by Monday, don't hesitate to ping me again.