search

tpitale / mail_room

Forward mail from gmail IMAP to a callback URL or job worker, simply.
MIT License
195 stars 51 forks source link

Fix possible race condition in mailbox_watcher.rb quit method #78

Closed galet closed 8 years ago

galet commented 8 years ago

Fixes undefined method `join' for nil:NilClass in quit method. Issue #77.

Exception: 2016-07-26_08:31:54.08717 /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/mail_room-0.8.0/lib/mail_room/mailbox_watcher.rb:50:in quit': undefined methodjoin' for nil:NilClass (NoMethodError) 2016-07-26_08:31:54.08721 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/mail_room-0.8.0/lib/mail_room/coordinator.rb:30:in each' 2016-07-26_08:31:54.08721 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/mail_room-0.8.0/lib/mail_room/coordinator.rb:30:inquit' 2016-07-26_08:31:54.08722 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/mail_room-0.8.0/lib/mail_room/coordinator.rb:25:in ensure in run' 2016-07-26_08:31:54.08722 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/mail_room-0.8.0/lib/mail_room/coordinator.rb:25:inrun' 2016-07-26_08:31:54.08722 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/mail_room-0.8.0/lib/mail_room/cli.rb:52:in `start'