tpjg / goriakpbc

A golang riak client inspired by the Ruby riak-client from Basho and riakpbc from mrb
Other
127 stars 27 forks source link

SetChanWaitTimeout does not use time.Duration #67

Closed tpjg closed 10 years ago

tpjg commented 10 years ago

The SetChanWaitTimeout() function uses an int instead of the more appropriate time.Duration. I plan to create a patch that will use time.Duration instead.

I realize this means some existing programs may break if they're using the SetChanWaitTimeout() function.

So, especially @etix , please be aware of this small API change.

etix commented 10 years ago

I've been following the topic about the switch to time.Duration. Thanks a lot.

tpjg commented 10 years ago

Closed in #66