Fix minor bug in key-up function and dry code

tplai / kbsim

Mechanical keyboard simulator website w/ a typing test. Offers 10+ unique switch sounds, layouts, and keyboard colors for an oddly satisfying typing experience.

https://kbs.im

MIT License

171 stars 29 forks source link

Fix minor bug in key-up function and dry code #34

Open tuliren opened 2 years ago

tuliren commented 2 years ago

Thank you for creating this amazing repo!
This PR fixes a minor bug in the handleKeyMouseUp function.
- This function should retrieve the release field, instead of the press field.
- This bug does not cause any issue though, because both release and press field contain the same special keys (e.g. SPACE).
Also four functions are dried:
- handleKeyDown now reuses handleKeyMouseDown.
- handleKeyUp now reuses handleKeyMouseUp.