I've been doing some testing on the getOccurrencesBetween() function and found a line that appears to reference an object variable that doesn't exist. Here is the code in question:
Line 525 of When.php (introduced in de0cd0da5ee017ed4cc2aa81068b6ef3999e7380):
if (isset($thisClone->limit)) {
$thisClone->limit = $thisClone->limit - 200;
}
Under what condition would $thisClone->limit be set?
I am wondering if what was meant here was a reference to the $limit variable set while calling the getOccurrencesBetween() function. If so, $limit isn't an object variable and the check on $thisClone->limit will return false even if getOccurrencesBetween() is called with a limit.
I've been doing some testing on the
getOccurrencesBetween()
function and found a line that appears to reference an object variable that doesn't exist. Here is the code in question:Line 525 of When.php (introduced in de0cd0da5ee017ed4cc2aa81068b6ef3999e7380):
Under what condition would
$thisClone->limit
be set?I am wondering if what was meant here was a reference to the
$limit
variable set while calling thegetOccurrencesBetween()
function. If so,$limit
isn't an object variable and the check on$thisClone->limit
will returnfalse
even ifgetOccurrencesBetween()
is called with a limit.Am I missing something?