search

tplaner / When

PHP Date Recursion library
https://github.com/tplaner/When
MIT License
513 stars 96 forks source link

fix implode calls #80

Closed remicollet closed 3 years ago

remicollet commented 3 years ago

With PHP 8

Failed asserting that exception of type "TypeError" matches expected exception "InvalidArgumentException". Message was: "implode(): Argument #2 ($array) must be of type ?array, string given" at

Using this patch

PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.0.4RC1
Configuration: /dev/shm/BUILD/When-09182e1707085382b8207c480120e96e98880563/phpunit.xml

...............................................................  63 / 197 ( 31%)
............................................................... 126 / 197 ( 63%)
............................................................... 189 / 197 ( 95%)
........                                                        197 / 197 (100%)

Time: 321 ms, Memory: 4.00MB

OK (197 tests, 1972 assertions)
tplaner commented 3 years ago

Thanks for your contribution.