search

tplaner / When

PHP Date Recursion library
https://github.com/tplaner/When
MIT License
513 stars 96 forks source link

Build RRule using BYHOUR, BYMINUTE, BYSECOND #86

Closed boryn closed 3 years ago

boryn commented 3 years ago

The method was missing BYHOUR, BYMINUTE, BYSECOND

PS. Could we change torrule() to toRrule()? The library uses camel case for method names. I can see my previous commit was not included or overwritten?

tplaner commented 3 years ago

I've gone ahead and changed it to toRrule().

I'm honestly not sure why I originally made all of the function names all lowercase for the rules. Luckily PHP's function names are case insensitive and it doesn't even throw an exception.