search

tplaner / When

PHP Date Recursion library
https://github.com/tplaner/When
MIT License
513 stars 96 forks source link

`$startDate` and `$endDate` could be accepted as `instanceof \DateTimeImmutable` #88

Closed boryn closed 3 years ago

boryn commented 3 years ago

IMHO $startDate and $endDate could/should be accepted as well as the instances of DateTimeImmutable.

PS. Very easy to implement at dateTimeObject() but was not sure about occursOn() and that's why I have not prepared the PR.

tplaner commented 3 years ago

Take a look at the last commit: https://github.com/tplaner/When/commit/84d280a49f6d3acc5515b9b3436f42b5b710a54e