tplaner / When

PHP Date Recursion library
https://github.com/tplaner/When
MIT License
513 stars 96 forks source link

Update type hints to work with php 8.4 #96

Open eileenmcnaughton opened 1 month ago

eileenmcnaughton commented 1 month ago

We are successfully using this package with php 7.4 through to 8.3. However, php 8.4 has an issue with these type hints

When\InvalidCombination::__construct(): Implicitly marking parameter $previous as nullable is deprecated, the explicit nullable type must be used instead - it appears to me that these should still work on php 7.1 (if you still want to support that) https://dev.to/alkhatibdev/evolution-of-type-hinting-in-php-9gm