search

tplgy / bonefish

C++ WAMP application router that enables building applications from loosely-coupled components.
Apache License 2.0
55 stars 33 forks source link

Several commits for finishing up native connection support #24

Closed davidchappelle closed 9 years ago

jpetso commented 9 years ago

Nice patches overall, I've got a few questions and suggestions though.

Your patches make the buildbot fail, which is probably not your fault but can you look into fixing the clock_gettime() symbol that can't be referenced? According to the Internet, clock_gettime() is defined in librt which is a dependency for some versions of glibc including apparently the one provided by the Travis CI build server. A FindRT.cmake module (used by bonefish CMakeLists.txt scripts) should fix it:

find_library(RT_LIBRARY NAMES rt)
# Handle the QUIETLY and REQUIRED arguments and set RT_FOUND to true
# if all listed variables are true.
include(FindPackageHandleStandardArgs)
find_package_handle_standard_args(RT DEFAULT_MSG RT_LIBRARY)
if (RT_FOUND)
    set(RT_LIBRARIES ${RT_LIBRARY})
else()
    set(RT_LIBRARIES )
endif()
mark_as_advanced(RT_LIBRARIES)

It's sort of unfortunate that find_package(Boost) or find_package(Threads) apparently don't take care of this.

jpetso commented 9 years ago

Thanks for the patch, and for addressing my comments!