search

tplgy / bonefish

C++ WAMP application router that enables building applications from loosely-coupled components.
Apache License 2.0
55 stars 33 forks source link

Add support for progressive call results #34

Closed davidchappelle closed 8 years ago

davidchappelle commented 8 years ago

This commit adds in advanced profile support for progressive call results. This allows for large result sets to be returned to a caller in smaller chunks. It includes several small fixes as well related to call processing. Big thanks to @estan and @pramukta for helping put this together.

Resolves: #9

jpetso commented 8 years ago

Hm... something seems weird with that Travis build. Let me try restarting it and see it that makes a difference.

jpetso commented 8 years ago

Travis build seems to have succeeded after restarting.

Regarding the patch, I'm thinking bonefish should probably check whether the callee's features.progressive_call_results == true before attempting to forward the call detail? Not sure if any check is needed for the caller, I guess they wouldn't ask for a progressive call if they didn't implement it, but the spec says it MUST be announced so maybe there should be a check.

Finally, I think the README should get a listing of supported Advanced Profile features in a bullet list.

davidchappelle commented 8 years ago

I don't think we need to worry about forwarding checking and filtering call details to the callee. If the callee doesn't support them for some reason it should just ignore them. There was some discussion on this very topic on the wamp thread a while back but I don't think that a final decision was reached. I'll update the README.

jpetso commented 8 years ago

Okay. Personally I think that features are better off in the actual README.md than in ROADMAP.md which should ideally contain information about future directions, not current functionality. That's a minor thing though and a merge seems in order now :)