search

tplgy / bonefish

C++ WAMP application router that enables building applications from loosely-coupled components.
Apache License 2.0
55 stars 33 forks source link

array bounds fix (issue 44) #45

Closed VE3RQX closed 7 years ago

VE3RQX commented 7 years ago

Use of "index" (iterator of roles) against features will lead to bad places if there is more than 1 role.

davidchappelle commented 7 years ago

Not sure why the build keeps failing for g++4.8. Seems to flip flop back and forth between the release and debug build. @jpetso is there any way we can see specifically why g++ 4.8 is failing? Should we roll it back to g++ 4.7?

davidchappelle commented 7 years ago

Actually it looks like we are hitting some kind of build timeout and travis is just killing the build. According to the docs, if a build step produces no output for > 10 minutes then the build is killed.

Build failed at an elapsed time 9 min 59 sec

I would tweak the build config to see if more time would solve the issue but I don't seem to have permissions to modify it.

davidchappelle commented 7 years ago

Clearly this pull request isn't responsible for the build failure so I am going to just go ahead and merge it.

jrogers commented 7 years ago

I will look into the build failure when I get a chance.

jrogers commented 7 years ago

Fixes #44