search

tpm2-software / tpm2-abrmd

TPM2 Access Broker & Resource Management Daemon implementing the TCG spec.
https://github.com/tpm2-software/tpm2-abrmd
BSD 2-Clause "Simplified" License
116 stars 100 forks source link

“setLocality” Not implemented while using abrmd with “--tcti=socket” #359

Open leeehui opened 6 years ago

leeehui commented 6 years ago

In my opinion, the following error should only occur when using abrmd with “--tcti=device”, because "setLocaliy" function in tpm2-tss has an implementation(SocketSetLocality) with socket tcti. but, there is still an error showing setlocality is not supported even using “--tcti=socket” .

ERROR: "GDBus.Error:com.intel.tss2.Tabrmd.Error.NotImplemented: setLocality function not implemented."

I know nothing about DBus, so I wonder if the above analysis is right. thanks.

flihp commented 6 years ago

You're right that it's possible to cancel commands if the TCTI that the tabrmd is using on the backend supports the command. Someone has to write the code to get the cancel command from the client, down through the daemon though and that's non-trivial. Would love to review a patch adding the feature.

leeehui commented 5 years ago

@flihp
I’m confused about your last comment. Did you mean, if the abrmd receives a setlocality request, it may cancel the tpm command that is currently being executed?