search

tpm2-software / tpm2-tools

The source repository for the Trusted Platform Module (TPM2.0) tools
https://tpm2-software.github.io
717 stars 378 forks source link

Stack Smashing Detected error on tpm2_createpolicy 3.2.0 #1632

Closed dnoliver closed 5 years ago

dnoliver commented 5 years ago

Clevis with tpm2-tools-3.1.4-1.fc29.x86_64 worked fine, as noted in https://github.com/latchset/clevis/issues/102

Clevis with tpm2-tools-3.2.0-1.fc30.x86_64 is running into this issue, as noted in https://github.com/latchset/clevis/issues/109

Error Message

[root@fedora-server-1 ~]# clevis luks bind -d /dev/nvme0n1p1 tpm2 '{"pcr_bank":"sha1","pcr_ids":"0,1,2,3,4,5,6,7,8,9"}'

*** stack smashing detected ***: <unknown> terminated
/usr/bin/clevis-encrypt-tpm2: line 133: 10496 Aborted                 (core dumped) tpm2_createpolicy -Q -P -L "$pcr_bank":"$pcr_ids" -F $TMP/pcr.digest -f $TMP/pcr.policy

Versions 

[root@fedora-server-1 ~]# rpm -qa clevis* tpm* cryptsetup* luks* libjose*

tpm2-tools-3.2.0-1.fc30.x86_64
tpm2-tss-2.2.3-1.fc30.x86_64
cryptsetup-libs-2.1.0-3.fc30.x86_64
cryptsetup-2.1.0-3.fc30.x86_64
clevis-luks-11-5.fc30.x86_64
libjose-10-4.fc30.x86_64
clevis-11-5.fc30.x86_64
luksmeta-9-2.fc29.x86_64

@martinezjavier suggested that this is a problem with the tpm2_createpolicy command in https://github.com/latchset/clevis/issues/109#issuecomment-517039214

I remember that there was some build with "hardening" enabled done lately, could that be causing this issue?

diabonas commented 5 years ago

This is the same issue as #778: it is not possible to use more than 8 PCRs due to limitations of the TPM 2.0 specification. Of course tpm2_createpolicy shouldn't crash regardless, and this was fixed on master in #780, which produces the much more helpful error message

ERROR: Number of PCR is limited to 8
ERROR: Could not build pcr policy
ERROR: Unable to run tpm2_createpolicy

I have therefore opened #1633 to backport this fix to the 3.X branch as well.

diabonas commented 5 years ago

This was already reported for tpm2-tools-3.1.4-1.fc30.x86_64 in #1389, but the commit 9685ea263f994537430323fb1681b210395eee7c referenced there doesn't seem to be sufficient to fix the issue: I can reproduce the crash with the Fedora binaries as well as with my self-compiled binaries based on the current 3.X branch. After applying the fix in #1633, the program exits cleanly with an error message instead of crashing.

williamcroberts commented 5 years ago

Does #1633 and #1639 fix the issue?

williamcroberts commented 5 years ago

We should also probably add a test for this...

dnoliver commented 5 years ago

@williamcroberts yes, there is no crash now. From clevis, I get a Command 'clevis-encrypt-tpm-{.......}' is invalid, instead of the previous stack smashing detected problem.

williamcroberts commented 5 years ago

@dnoliver I think the parser logic is limited to 8 pcrs as @martinezjavier mentioned. We could improve the parser to not suck, if someone wants to do that.