search

tpm2-software / tpm2-totp

Attest the trustworthiness of a device against a human using time-based one-time passwords
https://tpm2-software.github.io
BSD 3-Clause "New" or "Revised" License
164 stars 36 forks source link

configure.ac: remove redundant code from AC_ARG_ENABLE #10

Closed dilyanpalauzov closed 5 years ago

dilyanpalauzov commented 5 years ago

Users assume, unless otherwise stated, that each ./configure feature has two states. If ./configure --help prints --enable-X this implies that the feature is disabled by default. There is no need to emit “(default: no)”.

By default, when ./configure --enable-X is called, and there is AC_ARG_ENABLE(x, …) in configure.ac, autoconf sets the variable enable_x to yes. Likewise, when ./configure --disalbe-X is called, automake sets the variable enable_x to no.

codecov[bot] commented 5 years ago

Codecov Report

Merging #10 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #10   +/-   ##
=======================================
  Coverage   85.25%   85.25%           
=======================================
  Files           3        3           
  Lines         658      658           
=======================================
  Hits          561      561           
  Misses         97       97

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 44fcb68...5b95f8a. Read the comment docs.