search

tpm2-software / tpm2-totp

Attest the trustworthiness of a device against a human using time-based one-time passwords
https://tpm2-software.github.io
BSD 3-Clause "New" or "Revised" License
164 stars 36 forks source link

Remove SHA384 from default banks #11

Closed AndreasFuchsTPM closed 5 years ago

AndreasFuchsTPM commented 5 years ago

Some TPMs give weird errors if SHA384 is selected as a bank. Removing it from default banks, thus only enabling SHA1 and SHA256 by default.

codecov[bot] commented 5 years ago

Codecov Report

Merging #11 into master will decrease coverage by 0.91%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage   85.25%   84.34%   -0.92%     
==========================================
  Files           3        3              
  Lines         658      658              
==========================================
- Hits          561      555       -6     
- Misses         97      103       +6
Impacted Files Coverage Δ
src/tpm2-totp.c 82.65% <ø> (ø) :arrow_up:
src/libtpm2-totp.c 84.66% <ø> (-1.42%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5547287...3c77a53. Read the comment docs.

AndreasFuchsTPM commented 5 years ago

Confirmed by private email