Closed jacmet closed 5 years ago
Merging #14 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #14 +/- ##
=======================================
Coverage 84.34% 84.34%
=======================================
Files 3 3
Lines 658 658
=======================================
Hits 555 555
Misses 103 103
Impacted Files | Coverage Δ | |
---|---|---|
src/tpm2-totp.c | 82.65% <100%> (ø) |
:arrow_up: |
src/libtpm2-totp.c | 84.66% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ed86a39...f659971. Read the comment docs.
@jacmet Would you want this cherry-picked ot a bugfix 0.1.2 release ?
@AndreasFuchsSIT that would be great! I'm currently packaging tpm2-totp in Buildroot (using v0.1.1), so it would be good to not have to carry the patch locally
@jacmet Done. P.S. Do you have a link ?
I didn't post the series yet, I'll send you a link once ready
Buildroot patches: https://patchwork.ozlabs.org/project/buildroot/list/?series=101467
Building currently gives the following warnings (which fails the build because of Werror) about format string mismatches:
src/tpm2-totp.c:343:23: error: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘uint64_t’ {aka ‘long long unsigned int’} [-Werror=format=] printf("%s%06ld", timestr, totp);