Closed diabonas closed 5 years ago
Merging #30 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #30 +/- ##
=======================================
Coverage 80.46% 80.46%
=======================================
Files 5 5
Lines 819 819
=======================================
Hits 659 659
Misses 160 160
Impacted Files | Coverage Δ | |
---|---|---|
src/libtpm2-totp.c | 84.66% <ø> (ø) |
:arrow_up: |
test/libtpm2-totp.c | 81.25% <ø> (ø) |
:arrow_up: |
src/tpm2-totp-tcti.c | 52.23% <ø> (ø) |
:arrow_up: |
src/plymouth-tpm2-totp.c | 77.02% <ø> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1a90bdc...2fab4ce. Read the comment docs.
tpm2-totp.h
doesn't need to include the fulltss2/tss2_esys.h
because it doesn't any of these functions or types, it only needstss2/tss2_tcti.h
for theTSS2_TCTI_CONTEXT
type. Also remove some unnecessary or duplicate headers with the help of deheader.ldd -u -r
. It doesn't fix all problems though:libtpm2-totp.so
includes an unnecessary reference tolibtss2-sys.so
. This is an upstream problem with the tpm2-tss pkg-config files, see https://github.com/tpm2-software/tpm2-tss/pull/1417 for a potential solution.libtpm2-totp.so
. Similar to the changes to libqrencode and libdl, we can remove it fromAM_CFLAGS
/AM_LDADD
, but this doesn't help since we use libtool which automatically links all library dependencies into any binary using the library. Changing this behaviour requires a patched version of libtool as provided e.g. by Debian.