Closed diabonas closed 5 years ago
Merging #40 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #40 +/- ##
=======================================
Coverage 80.48% 80.48%
=======================================
Files 5 5
Lines 820 820
=======================================
Hits 660 660
Misses 160 160
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9e68586...c172117. Read the comment docs.
Instead of hardcoding a path for DejaVu Sans which might not be available or in a different location, use
fc-match
to use "the normal fontconfig matching rules to find the best font available".I am not entirely happy that we have to add
label.so
and a font manually in our hooks, this is something that either upstream plymouth or the individual distributions should do depending on the selected plymouth theme. Debian and openSUSE seem to do that, Arch and Fedora (probably, not completely sure about that) don't. Therefore we do it in our own hooks as portable as possible since possibly doing it twice won't lead to conflicts.