search

tpm2-software / tpm2-totp

Attest the trustworthiness of a device against a human using time-based one-time passwords
https://tpm2-software.github.io
BSD 3-Clause "New" or "Revised" License
163 stars 36 forks source link

dist: let fontconfig choose an appropriate font #40

Closed diabonas closed 5 years ago

diabonas commented 5 years ago

Instead of hardcoding a path for DejaVu Sans which might not be available or in a different location, use fc-match to use "the normal fontconfig matching rules to find the best font available".

I am not entirely happy that we have to add label.so and a font manually in our hooks, this is something that either upstream plymouth or the individual distributions should do depending on the selected plymouth theme. Debian and openSUSE seem to do that, Arch and Fedora (probably, not completely sure about that) don't. Therefore we do it in our own hooks as portable as possible since possibly doing it twice won't lead to conflicts.

codecov[bot] commented 5 years ago

Codecov Report

Merging #40 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   80.48%   80.48%           
=======================================
  Files           5        5           
  Lines         820      820           
=======================================
  Hits          660      660           
  Misses        160      160

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9e68586...c172117. Read the comment docs.