diabonas commented 5 years ago

dist/tpm2-totp.pc is generated by AC_CONFIG_FILES and therefore cleaned up automatically by Autoconf.
As in https://github.com/tpm2-software/tpm2-tools/pull/1590, -O2 needs to be added to the compiler flags to avoid a compilation warning/error due to fortification.
The Autoconf Archive version in Travis CI doesn't support AX_ADD_FORTIFY_SOURCE, ax_add_fortify_source.m4 from a newer version needs to be installed.

codecov[bot] commented 5 years ago

Codecov Report

Merging #49 into master will decrease coverage by 0.09%. The diff coverage is 50%.

@@            Coverage Diff            @@
##           master      #49     +/-   ##
=========================================
- Coverage   80.48%   80.38%   -0.1%     
=========================================
  Files           5        5             
  Lines         820      821      +1     
=========================================
  Hits          660      660             
- Misses        160      161      +1

Impacted Files	Coverage Δ
src/tpm2-totp.c	`81.73% <50%> (-0.4%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2abbb2a...41b95aa. Read the comment docs.

diabonas commented 5 years ago

Enabling -O2 produces a false positive scan-build warning for Travis CI, similar to #32. To fix this, explicitly check that str is not NULL, which at the same time obviates the need to initialise saveptr in #33.

tpm2-software / tpm2-totp

build: cleanup DISTCLEANFILES and add -O2 #49

Codecov Report