search

tpm2-software / tpm2-totp

Attest the trustworthiness of a device against a human using time-based one-time passwords
https://tpm2-software.github.io
BSD 3-Clause "New" or "Revised" License
163 stars 36 forks source link

Use tss2-tctildr #53

Closed diabonas closed 5 years ago

diabonas commented 5 years ago

Since https://github.com/tpm2-software/tpm2-tss/pull/1470 has been merged upstream, we can now switch to tss2-tctildr and remove our own TCTI handling code. This relies on the not yet released tpm2-tss 2.3, so I guess we could hold off merging this at least until the first release candidate for 2.3 is tagged.

Fixes: #19

codecov[bot] commented 5 years ago

Codecov Report

Merging #53 into master will increase coverage by 3.09%. The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   80.38%   83.48%   +3.09%     
==========================================
  Files           5        4       -1     
  Lines         821      757      -64     
==========================================
- Hits          660      632      -28     
+ Misses        161      125      -36
Impacted Files Coverage Δ
src/tpm2-totp.c 82.38% <100%> (+0.65%) :arrow_up:
src/plymouth-tpm2-totp.c 80% <100%> (+2.97%) :arrow_up:
test/libtpm2-totp.c 83.33% <75%> (+2.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fe09aa8...ac50240. Read the comment docs.