tpm2-software / tpm2-totp

Attest the trustworthiness of a device against a human using time-based one-time passwords
https://tpm2-software.github.io
BSD 3-Clause "New" or "Revised" License
163 stars 36 forks source link

Improve initramfs hooks for systems without plymouth #57

Closed diabonas closed 4 years ago

diabonas commented 4 years ago

Improve the user experience for systems without plymouth installed, e.g. for a default Arch Linux installation: instead of blocking the initramfs until the TOTP has been verified, start tpm2-top in the background and output the TOTP to stdout every 30 seconds. This way users can enter their disk encryption password and verify the TOTP in parallel. The updated TOTP is shown in a new line without disrupting the password entry.

These changes concern mkinitcpio and dracut and have been tested on bare metal. For initramfs-tools I haven't found a way of including scripts conditionally on whether plymouth is installed or not (and I don't have a physical installation to test with), so stay with the current plymouth-only version for now.

With the most recent doxygen version 1.8.16, I get a warning regarding obsolete Doxyfile options during compilation, so I used doxygen -u Doxyfile.in to update (in a backwards-compatible way).

codecov[bot] commented 4 years ago

Codecov Report

Merging #57 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #57   +/-   ##
======================================
  Coverage    83.5%   83.5%           
======================================
  Files           4       4           
  Lines         758     758           
======================================
  Hits          633     633           
  Misses        125     125

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a144c27...25b95ec. Read the comment docs.