search

tpm2-software / tpm2-tss-engine

OpenSSL Engine for TPM2 devices
https://tpm2-software.github.io
BSD 3-Clause "New" or "Revised" License
148 stars 97 forks source link

tpm2-tss-engine: add digest like sha1,sha256 #234

Closed aaronUniontech closed 2 years ago

aaronUniontech commented 2 years ago

Signed-off-by: zhangya zhangya@uniontech.com

AndreasFuchsTPM commented 2 years ago

I'm sorry, but I do not see a reason to have the TPM calculate a digest. Could you explain to me, why this would be an advantage ? Because otherwise, I'd have to reject this PR

aaronUniontech commented 2 years ago

I'm sorry, but I do not see a reason to have the TPM calculate a digest. Could you explain to me, why this would be an advantage ? Because otherwise, I'd have to reject this PR

maybe all the work can be done by the hardwork. yes, it's not such necessary.

williamcroberts commented 2 years ago

I'm sorry, but I do not see a reason to have the TPM calculate a digest. Could you explain to me, why this would be an advantage ? Because otherwise, I'd have to reject this PR

maybe all the work can be done by the hardwork. yes, it's not such necessary.

The TPM is very slow, so in general unless you're working in a way where you need a ticket, theirs no point to using the TPM to hash over software.

AndreasFuchsTPM commented 2 years ago

So I appreciate the effort of this implementation but I'll have to decline the PR. I'm sorry, but there is no advantage, only disadvantages in calculating the digest inside the TPM.