search

tpm2-software / tpm2-tss-engine

OpenSSL Engine for TPM2 devices
https://tpm2-software.github.io
BSD 3-Clause "New" or "Revised" License
150 stars 100 forks source link

Using composite actions for CI #243

Closed malikabhi05 closed 2 years ago

malikabhi05 commented 2 years ago

This PR changes the CI slightly by pointing the builds to common custom composite actions. These actions are currently under malikabh/test-ac and must ideally be moved to their own repo in the tpm2-software org.

This PR is currently for review and discussion and is opened as a draft PR. If everything is good then it can be converted into a proper PR and merged.

AndreasFuchsTPM commented 2 years ago

What's the difference of a composite action to what we currently have ?

williamcroberts commented 2 years ago

What's the difference of a composite action to what we currently have ?

The goal is to move all the common stuff out to the other repo so only the non-common stuff remains in the .ci folders for each project.

AndreasFuchsTPM commented 2 years ago

IMHO you should rebase/sQuash/repack the commits; esp the mention of your private repo should disappear...

williamcroberts commented 2 years ago

The action is complete, it's https://github.com/tpm2-software/tpm2-tss-engine/actions/runs/1714787099

So approving and merging.