search

tpm2-software / tpm2-tss

OSS implementation of the TCG TPM2 Software Stack (TSS2)
https://tpm2-software.github.io
BSD 2-Clause "Simplified" License
733 stars 360 forks source link

Do we need a 1.3.1? #663

Closed jiazhang0 closed 6 years ago

jiazhang0 commented 6 years ago

The formal 1.3.0 has such a build failure:

libtool: compile:  gcc -DPACKAGE_NAME=\"tpm2-tss\" -DPACKAGE_TARNAME=\"tpm2-tss\" -DPACKAGE_VERSION=\"1.3.0\" "-DPACKAGE_STRING=\"tpm2-tss 1.3.0\"" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DPACKAGE=\"tpm2-tss\" -DVERSION=\"1.3.0\" -DHAVE_CMOCKA=1 -I. -I./include -I./sysapi/include -Wall -Werror -Wno-int-in-bool-context -Wno-extern-c-compat -Wformat -Wformat-security -fstack-protector-all -fpic -fPIC -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wno-missing-braces -g -O2 -MT tcti/tcti_libtcti_socket_la-platformcommand.lo -MD -MP -MF tcti/.deps/tcti_libtcti_socket_la-platformcommand.Tpo -c tcti/platformcommand.c  -fPIC -DPIC -o tcti/.libs/tcti_libtcti_socket_la-platformcommand.o
libtool: compile:  gcc -DPACKAGE_NAME=\"tpm2-tss\" -DPACKAGE_TARNAME=\"tpm2-tss\" -DPACKAGE_VERSION=\"1.3.0\" "-DPACKAGE_STRING=\"tpm2-tss 1.3.0\"" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DPACKAGE=\"tpm2-tss\" -DVERSION=\"1.3.0\" -DHAVE_CMOCKA=1 -I. -I./include -I./sysapi/include -Wall -Werror -Wno-int-in-bool-context -Wno-extern-c-compat -Wformat -Wformat-security -fstack-protector-all -fpic -fPIC -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wno-missing-braces -g -O2 -MT tcti/tcti_libtcti_socket_la-platformcommand.lo -MD -MP -MF tcti/.deps/tcti_libtcti_socket_la-platformcommand.Tpo -c tcti/platformcommand.c -o tcti/tcti_libtcti_socket_la-platformcommand.o >/dev/null 2>&1
mv -f tcti/.deps/tcti_libtcti_socket_la-platformcommand.Tpo tcti/.deps/tcti_libtcti_socket_la-platformcommand.Plo
make: *** No rule to make target `tcti/tcti_socket.c', needed by `tcti/tcti_libtcti_socket_la-tcti_socket.lo'.  Stop.

and the latest master branch fixed this issue. Do you have a plan to release a 1.3.1 with the fix for this issue?

Thanks

martinezjavier commented 6 years ago

@jiazhang0 that error seems to be caused by left overs from built artifacts from a different branch.

I guess you built from master, then changed to 1.3.0 branch and tried to build there? I'm not sure if the build system should cope with those. If the build work after a clean sate (i.e: after make distclean && configure) then I think that there's no issue.

jiazhang0 commented 6 years ago

@martinezjavier As you said, a clean build doesn't have this build failure. You are so good! Thank you!

martinezjavier commented 6 years ago

@jiazhang0 great, glad that I could be of any help.