Restore using __builtin_available for macos (redux)

tpoechtrager / cctools-port

Apple cctools port for Linux and *BSD

731 stars 168 forks source link

Restore using __builtin_available for macos (redux) #153

Closed h-vetinari closed 2 months ago

h-vetinari commented 2 months ago

This is a rebase of #116, which initially got the logic inverted. This was fixed on conda-forge side in https://github.com/conda-forge/cctools-and-ld64-feedstock/commit/167d022955b3055fd98e81613b48050cc3bbec04, and we've been shipping that patch ever since.

Closes #116

tpoechtrager commented 2 months ago

I have added #ifdefs for HAVE_CLOCK_GETTIME there. I don't see why restoring __builtin_available would be necessary.

h-vetinari commented 2 months ago

I have added #ifdefs for HAVE_CLOCK_GETTIME there. I don't see why restoring __builtin_available would be necessary.

My goal was to reduce the amount of patches we carry, if possible. I don't know what @isuruf's exact intention was with this, but assuming the __builtin_available bits aren't necessary anymore, why not delete all the #if 0 blocks?

tpoechtrager commented 2 months ago

They could be deleted, but for easier merging of future versions I decided to add #if 0 blocks instead.