tpoechtrager / osxcross

Mac OS X cross toolchain for Linux, FreeBSD, OpenBSD and Android (Termux)
GNU General Public License v2.0
2.8k stars 318 forks source link

Add support for macOS 13.2 and 13.3 #382

Closed joseluisq closed 10 months ago

joseluisq commented 1 year ago

On the latest Macos 13.3.1 with Xcode 14.3, I get the following error when testing this PR. Any idea why?

$ ./tools/gen_sdk_package.sh
# found Xcode: /Applications/Xcode.app
# packaging MacOSX13.3 SDK (this may take several minutes) ...
# cp: cannot overwrite directory /tmp/sOBW08OLD38/MacOSX13.3.sdk/usr/include/c++/v1/__string with non-directory Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__string
joseluisq commented 1 year ago

I found that when copying to the temp directory at line 187 https://github.com/tpoechtrager/osxcross/blob/ed079949e7aee248ad7e7cb97726cd1c8556afd1/tools/gen_sdk_package.sh#L186-L188

the __string libc++ header is already a directory rather than a regular file and has content.

$ ll /tmp/sOBW08OLD38/MacOSX13.3.sdk/usr/include/c++/v1/__string/
# char_traits.h
# extern_template_lists.h
radusalagean commented 1 year ago

@joseluisq this helped me: https://github.com/tpoechtrager/osxcross/issues/383#issuecomment-1580487598

joseluisq commented 1 year ago

@radusalagean I did something similar too like removing the __string dir before copying but I was not sure if that workaround should be fine. That's why I asked above. So it would be great to know the maintainer's opinion about if https://github.com/tpoechtrager/osxcross/issues/383#issuecomment-1580487598 could be acceptable or not.