search

tpoikela / uvm-python

UVM 1.2 port to Python
Apache License 2.0
243 stars 46 forks source link

Initial TLM2 Implementation #11

Closed mballance closed 4 years ago

mballance commented 4 years ago

I've completed conversion of the TLM2 classes and have the simple 'blocking' example running

mballance commented 4 years ago

Hi Tuomas, Looks like this PR and commits from you in the TLM2 area came in around the same time. I'll be happy to re-merge this PR with 'master' to resolve the conflicts if you'd like.

Thanks, Matthew

tpoikela commented 4 years ago

Hi Matthew

Yes, that would be perfect if you can merge. I saw that you had done much more work than I did for TLM2, so you can most likely override many, if not all, my changes.

-Tuomas

On Mon, 10 Feb 2020 at 17:56, Matthew Ballance notifications@github.com wrote:

Hi Tuomas, Looks like this PR and commits from you in the TLM2 area came in around the same time. I'll be happy to re-merge this PR with 'master' to resolve the conflicts if you'd like.

Thanks, Matthew

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tpoikela/uvm-python/pull/11?email_source=notifications&email_token=ACG7SW33BK6W2ICZSXU3S33RCF2LZA5CNFSM4KSD7ZC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELJBIVI#issuecomment-584193109, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACG7SW45URZPTMJ2MNPAAWLRCF2LZANCNFSM4KSD7ZCQ .

mballance commented 4 years ago

Okay, I've completed the merge and the test still runs. One difference in our conversion is that I used UVMTlm, while you used UVMTLM. I resolved the difference in favor of the naming convention I used (UVMTlm...). Let me know if you'd like to go the other direction.

Thanks, Matthew

tpoikela commented 4 years ago

We should just make sure each class is named in similar fashion. I used UVMTLM in TLM1 classes, so let us go with that naming for now. It is lot of capital letters, especially in UVMTLMFIFO.

ti 11. helmik. 2020 klo 5.01 Matthew Ballance notifications@github.com kirjoitti:

Okay, I've completed the merge and the test still runs. One difference in our conversion is that I used UVMTlm, while you used UVMTLM. I resolved the difference in favor of the naming convention I used (UVMTlm...). Let me know if you'd like to go the other direction.

Thanks, Matthew

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/tpoikela/uvm-python/pull/11?email_source=notifications&email_token=ACG7SW4YI4CCM2QFUPQ3U73RCIIHVA5CNFSM4KSD7ZC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELLCODY#issuecomment-584460047, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACG7SWYKI47CCNDZ6S6EASLRCIIHVANCNFSM4KSD7ZCQ .

mballance commented 4 years ago

Hey Tuomas, just sent a PR your way to rename the UVMTlm classes to UVMTLM.

cmarqu commented 4 years ago

Awesome! The README still only talks about TLM 1.0 though.

tpoikela commented 4 years ago

Thanks for pointing out. To be updated soon. Also with minimal running example without simulator.

pe 14. helmik. 2020 klo 12.49 Colin Marquardt notifications@github.com kirjoitti:

Awesome! The README still only talks about TLM 1.0 though.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/tpoikela/uvm-python/pull/11?email_source=notifications&email_token=ACG7SW3GPX7W33FAAS37MYDRCZZLHA5CNFSM4KSD7ZC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELYNDLI#issuecomment-586207661, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACG7SW2N5UXQOY5ZKKJHTRLRCZZLHANCNFSM4KSD7ZCQ .