search

tpope / pickler

PIvotal traCKer Liaison to cucumbER
MIT License
299 stars 23 forks source link

PivotalTracker API v5 forces to use SSL #20

Closed cantonic closed 10 years ago

cantonic commented 10 years ago

We need to remove the option to disable SSL since the PivotalTracker API v5 only allows SSL connections.

tpope commented 10 years ago

Wasn't hard to fix this at a testing level. Try the ssl branch.

cantonic commented 10 years ago

thx @tpope. I'm gonna close this one.

tpope commented 10 years ago

I only checked the test suite. Please double check the tool as a whole still works and I'll merge it into master.

cantonic commented 10 years ago

isn't running the tests enough? I just tried some commands like pickler search and pickler pull ... and they are working fine.

cantonic commented 10 years ago

@tpope you shouldn't merge the ssl branch into master I guess since it is using v3 of the API.

tpope commented 10 years ago

But it's working, right? I wanted you to try it just to make sure there wasn't any funny business with SSL on v3, but it sounds like it's fine. Not sure why it was ever an option, really (though as I recall really early versions might not have supported SSL).

cantonic commented 10 years ago

yeah that's true. It makes the gem easier to configure. Remember to remove the according lines from the README :)

tpope commented 10 years ago

Good point. Fixed README and pushed.