Adding support for v5 api

tpope / pickler

PIvotal traCKer Liaison to cucumbER

MIT License

299 stars 23 forks source link

Adding support for v5 api #25

Closed mainephd closed 7 years ago

mainephd commented 7 years ago

Adds support for Tracker v5 API and JSON response type. Left in the legacy support for v3 and xml API

tpope commented 7 years ago

Please

Drop the bump commit
Drop the .idea ignore (that belongs in your personal config)
Change the commit message to read Add, not Adding

mainephd commented 7 years ago

Thanks for taking a look. Let me know if you want me to change anything else.

tpope commented 7 years ago

Puts spaces after the commas in method invocations.
Can we get rid of any of the XML fixtures?
Squash everything to one commit.

I'm not an active Tracker user at the moment, so I'm largely trusting you on your new implementation.

mainephd commented 7 years ago

the xml fixtures could be removed along with the xml specific parsing functions since the v5 of the API does not appear to support XML any longer.

tpope commented 7 years ago

Removing the XML support would be great, but I won't require it for merge. Can you delete the body of the commit message? "Remove environment specific folder ignore" and the like doesn't make sense now that you squashed out the part that added them.

mainephd commented 7 years ago

cool. That is complete now.

tpope commented 7 years ago

Looks good. I think the next step is to rip out the old XML stuff and then we can do a minor version bump.

mainephd commented 7 years ago

makes sense. i'll work on validating the changes without xml parsing logic