tpope / vim-fireplace

fireplace.vim: Clojure REPL support
https://www.vim.org/scripts/script.php?script_id=4978
1.75k stars 139 forks source link

Use 'user' namespace for class path, testing and evalparse operations. #221

Closed frenchy64 closed 9 years ago

frenchy64 commented 9 years ago

Similar to https://github.com/tpope/vim-leiningen/pull/9.

Notes:

tpope commented 9 years ago

How thoroughly have you tested this? I went through with a similar goal a while back but there were definitely places I couldn't change for one reason or another. (Your bullet points address at least some of those reasons, I would assume).

frenchy64 commented 9 years ago

I tested some common operations and it seemed to work, but it's still a concerning change.

I'm going to close this and send a few smaller pull requests that carefully fixes each case and tests them individually.

tpope commented 9 years ago

That sounds good. You should try without cider-nrepl installed, as it supersedes some of this code.